Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop a workflow during offload causes upper: no more rows in this result set #13220

Open
4 tasks done
shuangkun opened this issue Jun 19, 2024 · 4 comments · May be fixed by #13286
Open
4 tasks done

Stop a workflow during offload causes upper: no more rows in this result set #13220

shuangkun opened this issue Jun 19, 2024 · 4 comments · May be fixed by #13286
Labels
area/controller Controller issues, panics P3 Low priority type/bug

Comments

@shuangkun
Copy link
Member

Pre-requisites

  • I have double-checked my configuration
  • I have tested with the :latest image tag (i.e. quay.io/argoproj/workflow-controller:latest) and can confirm the issue still exists on :latest. If not, I have explained why, in detail, in my description below.
  • I have searched existing issues and could not find a match for this bug
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what did you expect to happen?

When the workflow updates the nodestatus to the database and deletes the old records, if someone stops the workflow during the update, a conflict will occur. However, reapply cannot parse woc.orig at this time, resulting in upper: no more rows in this result set

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

Any large workflow

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded
@shuangkun
Copy link
Member Author

Maybe we don't need to delete oldRecord when offload sace, because there is periodic cleanup.

@shuangkun shuangkun added the area/controller Controller issues, panics label Jun 19, 2024
@agilgur5 agilgur5 changed the title Stop a workflow cause "upper: no more rows in this result set" Stop a workflow cause upper: no more rows in this result set Jun 19, 2024
@agilgur5 agilgur5 changed the title Stop a workflow cause upper: no more rows in this result set Stop a workflow during offload causea upper: no more rows in this result set Jun 19, 2024
@agilgur5 agilgur5 changed the title Stop a workflow during offload causea upper: no more rows in this result set Stop a workflow during offload causes upper: no more rows in this result set Jun 19, 2024
@agilgur5 agilgur5 added the P3 Low priority label Jun 19, 2024
@jswxstw
Copy link
Member

jswxstw commented Jun 20, 2024

Maybe we don't need to delete oldRecord when offload sace, because there is periodic cleanup.

uid is the primary key, use insert on update instead?

@shuangkun
Copy link
Member Author

Maybe we don't need to delete oldRecord when offload sace, because there is periodic cleanup.

uid is the primary key, use insert on update instead?

This is similar to canceling the cleanup of old records in the offload save phase. Dehydrate and update are very close. If you insert after update, you need to save the offloadVersion generated in the Dehydrate phase.

shuangkun added a commit to shuangkun/argo-workflows that referenced this issue Jul 1, 2024
@shuangkun
fix: don't clean up old records when save. Fixes: argoproj#13220
5b4d5e4 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun linked a pull request Jul 1, 2024 that will close this issue
Open
@jswxstw
Copy link
Member

jswxstw commented Jul 1, 2024

This is similar to canceling the cleanup of old records in the offload save phase. Dehydrate and update are very close. If you insert after update, you need to save the offloadVersion generated in the Dehydrate phase.

Sorry, I misunderstood this issue, I thought it was a issue caused by workflow archiving before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/controller Controller issues, panics P3 Low priority type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: don't clean up old offloaded records during save. Fixes: #13220 shuangkun/argo-workflows
3 participants
@agilgur5 @jswxstw @shuangkun
-