Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing ".." in subdirectory of root doesn't work #46

Closed
rmccampbell opened this issue Dec 30, 2020 · 1 comment
Closed

Typing ".." in subdirectory of root doesn't work #46

rmccampbell opened this issue Dec 30, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@rmccampbell
Copy link

The .. shortcut results in an error '..' is not recognized as an internal or external command, operable program or batch file in C:\ or any directory directly below, such as C:\Users or C:\Program Files. It does work with a trailing slash ..\ however, and more dots like ... does work. In all deeper directories .. works without a slash.
@chrisant996
Copy link
Owner

chrisant996 commented Dec 30, 2020 •
edited
Loading

Drat. Thanks for reporting it!

It's really dumb: ... gets converted to ..\..\ but .. is left as-is. Without a trailing slash, it uses FindFirstFile because that's overall faster and more reliable. But with a trailing slash it uses GetFileAttributes to work around some quirks in a root directory.

It just needs to convert .. to ..\ as well.

@chrisant996 chrisant996 added the bug Something isn't working label Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rmccampbell @chrisant996
-