fix(lib): #2869 restrict pattern_map optimization #3440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixing tree-sitter#2869 by restricting pattern_map optimization in ts_query_new() i.e. do not select a second step which is immediate
|
Could you add a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #2869 by restricting pattern_map optimization in
ts_query_new().pattern_mapis used to efficiently spawn query states given the current node symbol.As an additional optimization,
italso handles patterns with a wildcard root given that the first child is not a wildcard itself.But for a pattern with a wildcard root, it is actually unsound to select a second step which is immediate,
because it will not be checked during the matching process here.
Moreover, it would be difficult to solve the unsoundness in
advance(), and restricting the optimization should be a good enough trade-off.