Patch-For-ReviewAutomation Metadata
ActivePublic
Watch Project

Members (2)

Watchers (22)

Details

Description

A tag automatically added by @gerritbot (patches in Gerrit) or @CodeReviewBot (patches in GitLab).

See wikitech:Gerrit Notification Bot and wikitech:GitLab/Phabricator for more information.

This tag is removed automatically by @Maintenance_bot when all patches attached to the ticket are merged or abandoned.

Recent Activity
View All

Today

LucasWerkmeister added a comment to T370578: High database load from MediaWiki\Extension\OAuth\Backend\Hooks::getUsedConsumerTags.

It looks like the error is already fixed since MariaDB 10.6.0, but remains reproducible in 10.5.25 (the latest patch release in the 10.5 series so far).

Sat, Jul 20, 2:54 PM · Patch-For-Review, MediaWiki-Platform-Team, mariadb-optimizer-bug, MediaWiki-extensions-OAuth

gerritbot added a project to T174666: Have a way to unsubscribe to the Newsletter in Notifications.: Patch-For-Review.

Sat, Jul 20, 2:47 PM · Patch-For-Review, Growth-Team-Filtering, Growth-Team, Notifications, MediaWiki-extensions-Newsletter

gerritbot added a project to T370536: cosmetic_changes.py: standardizePageFooter should use '*' and not ' ' as sort_key for Arabic Wikipedia (arwiki): Patch-For-Review.

Sat, Jul 20, 2:41 PM · Patch-For-Review, Pywikibot-Scripts, Pywikibot

gerritbot added a comment to T370573: ext.checkUser.temporaryaccount.rest breaking CI in RevisionSlider.

Change #1055535 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CheckUser@master] tests: qunit: Skip a potentially-broken test case

https://gerrit.wikimedia.org/r/1055535

Sat, Jul 20, 2:40 PM · Patch-For-Review, Revision-Slider, ci-test-error (WMF-deployed Build Failure), Temporary accounts, CheckUser

Anujagrawal added a comment to T321368: Move ScrollEndEventEmitter class to mobile.special.watchlist.scripts module.

@Jdlrobson i added a patch.

Sat, Jul 20, 2:30 PM · Patch-For-Review, MobileFrontend (MobileFrontend Special Pages), patch-welcome, good first task

gerritbot added a project to T370582: Remove or replace deployment-mwmaint02.deployment-prep.eqiad1.wikimedia.cloud: Patch-For-Review.

Sat, Jul 20, 2:22 PM · Patch-For-Review, Cloud-VPS (Debian Buster Deprecation), Beta-Cluster-Infrastructure

Southparkfan claimed T361386: Remove or replace deployment-parsoid12.deployment-prep.eqiad1.wikimedia.cloud.

deployment-parsoid14 has been installed with a Bullseye image.

Sat, Jul 20, 2:04 PM · Patch-For-Review, cloud-services-team, Cloud-VPS (Debian Buster Deprecation), Beta-Cluster-Infrastructure

gerritbot added a comment to T361386: Remove or replace deployment-parsoid12.deployment-prep.eqiad1.wikimedia.cloud.

Change #1055533 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[operations/mediawiki-config@master] LabsServices: replace parsoid endpoint

https://gerrit.wikimedia.org/r/1055533

Sat, Jul 20, 2:02 PM · Patch-For-Review, cloud-services-team, Cloud-VPS (Debian Buster Deprecation), Beta-Cluster-Infrastructure

gerritbot added a project to T361386: Remove or replace deployment-parsoid12.deployment-prep.eqiad1.wikimedia.cloud: Patch-For-Review.

Sat, Jul 20, 2:00 PM · Patch-For-Review, cloud-services-team, Cloud-VPS (Debian Buster Deprecation), Beta-Cluster-Infrastructure

LucasWerkmeister added a comment to T370578: High database load from MediaWiki\Extension\OAuth\Backend\Hooks::getUsedConsumerTags.

In T370578#10000202, @Tgr wrote:

I don't think we really need this query. We can just check change_tag_def.ctd_count instead. Just replace all the changeTagDefStore->getId() calls with a call to ChangeTagsStore::tagUsageStatistics() and intersect that with the result from the previous query.

Sat, Jul 20, 1:56 PM · Patch-For-Review, MediaWiki-Platform-Team, mariadb-optimizer-bug, MediaWiki-extensions-OAuth

Tgr added a comment to T370578: High database load from MediaWiki\Extension\OAuth\Backend\Hooks::getUsedConsumerTags.

(That will add a delay to new tags showing up on Special:Tags but IMO that's fine.)

Sat, Jul 20, 1:48 PM · Patch-For-Review, MediaWiki-Platform-Team, mariadb-optimizer-bug, MediaWiki-extensions-OAuth

Tgr added a comment to T370578: High database load from MediaWiki\Extension\OAuth\Backend\Hooks::getUsedConsumerTags.

Right, sorry, I misunderstood, I thought the query is reading from change_tag_def. Yeah that looks pretty bad.

Sat, Jul 20, 1:44 PM · Patch-For-Review, MediaWiki-Platform-Team, mariadb-optimizer-bug, MediaWiki-extensions-OAuth

Southparkfan added a comment to T370459: Remove or replace deployment-push-notifications01.deployment-prep.eqiad1.wikimedia.cloud (Buster deprecation).

^ after merging this change, deployment-push-notifications01 can be replaced with a Bookworm instance.

Sat, Jul 20, 1:34 PM · Patch-For-Review, Cloud-VPS (Debian Buster Deprecation), Beta-Cluster-Infrastructure, cloud-services-team

gerritbot added a project to T370459: Remove or replace deployment-push-notifications01.deployment-prep.eqiad1.wikimedia.cloud (Buster deprecation): Patch-For-Review.

Sat, Jul 20, 1:33 PM · Patch-For-Review, Cloud-VPS (Debian Buster Deprecation), Beta-Cluster-Infrastructure, cloud-services-team

Southparkfan added a comment to T361387: Replace or delete deployment-mediawiki[11-12].deployement-prep.eqiad1.wikimedia.cloud.

mediawiki11 and mediawiki12 are no longer in use, but still receive scap deployments. As soon as the two changes above have been merged, we can delete these instances.

Sat, Jul 20, 1:19 PM · Patch-For-Review, Cloud-VPS (Debian Buster Deprecation), cloud-services-team, Beta-Cluster-Infrastructure

gerritbot added a comment to T361387: Replace or delete deployment-mediawiki[11-12].deployement-prep.eqiad1.wikimedia.cloud.

Change #1055530 had a related patch set uploaded (by Southparkfan; author: Southparkfan):

[operations/puppet@production] deployment-prep: remove Buster appservers

https://gerrit.wikimedia.org/r/1055530

Sat, Jul 20, 1:16 PM · Patch-For-Review, Cloud-VPS (Debian Buster Deprecation), cloud-services-team, Beta-Cluster-Infrastructure

gerritbot added a project to T361387: Replace or delete deployment-mediawiki[11-12].deployement-prep.eqiad1.wikimedia.cloud: Patch-For-Review.

Sat, Jul 20, 12:42 PM · Patch-For-Review, Cloud-VPS (Debian Buster Deprecation), cloud-services-team, Beta-Cluster-Infrastructure

gerritbot added a comment to T369395: "Set source code repository in toolinfo to this repository" checkbox on repos/create screen is unexpectedly required.

Change #1052355 merged by jenkins-bot:

[labs/striker@master] tools: Setting SCM or issue tracker URL is optional

https://gerrit.wikimedia.org/r/1052355

Sat, Jul 20, 11:38 AM · Striker

LucasWerkmeister added a comment to T370578: High database load from MediaWiki\Extension\OAuth\Backend\Hooks::getUsedConsumerTags.

Hm, in ANALYZE, there’s a huge mismatch between filtered (0%) and r_filtered (100%):

Sat, Jul 20, 11:29 AM · Patch-For-Review, MediaWiki-Platform-Team, mariadb-optimizer-bug, MediaWiki-extensions-OAuth

Dreamy_Jazz added a comment to T370573: ext.checkUser.temporaryaccount.rest breaking CI in RevisionSlider.

The alternative is to skip these QUnit tests until we can find out what is causing the problem.

Sat, Jul 20, 11:25 AM · Patch-For-Review, Revision-Slider, ci-test-error (WMF-deployed Build Failure), Temporary accounts, CheckUser

Dreamy_Jazz added a comment to T370573: ext.checkUser.temporaryaccount.rest breaking CI in RevisionSlider.

Unfortunately, I cannot actually reproduce this on my local wiki because the tests pass in isolation there (which shouldn't occur if the issue is due to when the tests run).

Sat, Jul 20, 11:23 AM · Patch-For-Review, Revision-Slider, ci-test-error (WMF-deployed Build Failure), Temporary accounts, CheckUser

LucasWerkmeister added a comment to T370578: High database load from MediaWiki\Extension\OAuth\Backend\Hooks::getUsedConsumerTags.

I’m not sure what you mean… I can reliably reproduce the behavior that the query is being slow (ca. 2 seconds, sometimes a bit less) when to me it seems like it shouldn’t be:

Sat, Jul 20, 11:17 AM · Patch-For-Review, MediaWiki-Platform-Team, mariadb-optimizer-bug, MediaWiki-extensions-OAuth

Dreamy_Jazz added a comment to T370573: ext.checkUser.temporaryaccount.rest breaking CI in RevisionSlider.

For some reason the assert.timeout does nothing call does nothing (set to 1s and the test still hangs)...

Sat, Jul 20, 11:16 AM · Patch-For-Review, Revision-Slider, ci-test-error (WMF-deployed Build Failure), Temporary accounts, CheckUser

thiemowmde added a parent task for T370570: RevisionSlider box mode box looks out of place on dark mode with its white border: T370572: RevisionSlider slider uses white colors on dark mode.

Sat, Jul 20, 11:10 AM · WMDE-TechWish-Sprint-2024-07-10, dark-mode, Patch-For-Review, Revision-Slider

thiemowmde added a subtask for T370572: RevisionSlider slider uses white colors on dark mode: T370570: RevisionSlider box mode box looks out of place on dark mode with its white border.

Sat, Jul 20, 11:10 AM · Patch-For-Review, WMDE-TechWish, dark-mode, Revision-Slider

gerritbot added a comment to T370572: RevisionSlider slider uses white colors on dark mode.

Change #1055526 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Replace some more colors with LESS design tokens

https://gerrit.wikimedia.org/r/1055526