[KT-69327] Correct FloatingPointParser.initialParse method to handle specific cases with invalid exponent string value #5322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following command should start native stdlib tests: |
|
Thank you, @fzhinkin. Works like a charm. All native stdlib tests are green |
|
Thanks for the fix, merged as 63a95f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR should close KT-69327 issue.
Unfortunately, I was not able to run tests:
I executed
./gradlew installand thenJAVA_OPTS=-Didea.sync.active=true ./gradlew -p libraries/stdlib nativeTestbut got a compilation error related to classes inkotlin-native/runtime/src/main/kotlindirectory.If anyone knows how to execute the kotlin-native/runtime/test/text/StringNumberConversionNativeTest.kt test I would much appreciate it if you help me with that.
Please, let me know if anything else should be done in order to submit this PR.