Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update go to 1.22 #13258

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(deps): update go to 1.22 #13258

wants to merge 3 commits into from
+4,978 −8,997

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Jun 27, 2024 •
edited
Loading

Fixes: #13188

Motivation

This change updates golang to 1.22

Modifications

  • Dockerfiles were updated to 1.22
  • go.mod was updated to 1.22
  • ci/release workflows were updated to use 1.22
  • go-swagger was updated to address a panic
  • make pre-commit -B is responsible the majority the changes

Verification

E2E tests should be enough

@blkperl
chore(deps): update go to 1.22
1d15520 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
blkperl
blkperl commented Jun 27, 2024
View reviewed changes
Makefile
@@ -339,7 +339,7 @@ endif
$(GOPATH)/bin/swagger:
# update this in Nix when upgrading it here
ifneq ($(USE_NIX), true)
go install github.com/go-swagger/go-swagger/cmd/swagger@v0.28.0
go install github.com/go-swagger/go-swagger/cmd/swagger@v0.31.0
Copy link
Contributor Author

@blkperl blkperl Jun 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agilgur5 the swagger update has changed/deleted some files which seems unexpected.

@blkperl blkperl marked this pull request as ready for review June 27, 2024 21:05
agilgur5
agilgur5 reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't analyzed the Swagger update etc yet (not sure yet), but the go.mod and Dockerfile + Dockerfile.windows need updating for a new Go version as well

@agilgur5 agilgur5 linked an issue Jun 28, 2024 that may be closed by this pull request
go 1.22 upgrade #13188
Open
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/build Build or GithubAction/CI issues labels Jun 28, 2024
blkperl and others added 2 commits June 28, 2024 11:03
@blkperl
chore(deps): update dockerfile to go1.22
8ace23a 
Signed-off-by: william.vanhevelingen <william.vanhevelingen@acquia.com>
@blkperl
Merge branch 'main' into go1.22
334c3a5
@blkperl
Copy link
Contributor Author

blkperl commented Jul 2, 2024

@agilgur5 if the swagger changes are okay then this is good to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go 1.22 upgrade
2 participants
@blkperl @agilgur5
-