-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In 1.3.16.023688, screen height is detected incorrectly #281
Comments
The It is controlled by See Readline configuration variables. The pager prompt ( Very little information has been shared, so I can't say more than that. What is your |
Also, I cannot reproduce " Please elaborate on what you are seeing, what steps you're using, what your configuration is, etc. |
Apparently, it has to do with a This does not happen with Playing with the value above to say 5000, will make my 1170 possible completions when Running from I'm testing with no user-set configuration at all right now, meaning no _inputrc or clink_settings, other than the two line |
Aha! Good work, yes, I can confirm that. Thanks for finding the repro steps and the crucial detail! In Windows Terminal it always works correctly, but that's because Windows Terminal (intentionally) broke the console APIs, and the scrollback buffer height is hidden from console programs. The cause is a bug in 7bc131e (a change which fixed #262). It correctly uses the entire console width, but it needs to use the window height instead of the console height (the latter includes the entire scrollback buffer). |
v1.3.17 is published, with the fix. |
*phew* so glad you were able to figure it out with my shitty reproduction scenario, I was running out of options regarding troubleshooting this. On a related note, how does v1.3.17 is working fine btw, thank you. |
They're related, yes.
Since it's completions -- not rows of completions -- it can be a bit clumsy depending on the terminal width.
Basically the latter is "prompt if the possible matches will end up scrolling". |
I think I understand both options better now, thank you. |
Plus, not getting the
--More--
prompt after a full-page of results with eithercompletion-query-items
andcompletion-auto-query-items
anymore.Was testing with the following as
_inputrc
:While toggling values on and off and incrementing/decrementing
completion-query-items
and restaring the plaincmd.exe
window in between tests.clink.log
Tell me if more details or troubleshooting are needed.
The text was updated successfully, but these errors were encountered: