Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more error handling and more sanity checking #3

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adds more error handling and more sanity checking #3

wants to merge 2 commits into from

Conversation

clonemeagain
Copy link
Owner

@clonemeagain clonemeagain commented Jan 10, 2018 •
edited

Relates to thammanna/osticket-slack#11 (comment)

Hopefully correctly handles the possible/likely HTTP return codes from https://api.slack.com/changelog/2016-05-17-changes-to-errors-for-incoming-webhooks

  • Adds a "simplify and resend" feature for soft-fail responses.
  • Rewrite of logging, to use osTicket inbuilt logging system. Admin -> Settings -> System -> "Default Log Level". Set it to "DEBUG" to see the plugin working things out in your normal "Admin -> Dashboard -> System Logs"
  • Test!
  • Needs a bit of a cleanup, getting scraggly.
  • Message Queue.. there's a fair few, but the external ones depend on quite a few things and are likely not available, we could simply add a db_table and use that.. might be for the best.

@clonemeagain clonemeagain self-assigned this Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@clonemeagain clonemeagain

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@clonemeagain
-