Add .tag to Java Server Pages #6048

lildude · 2022-09-01T16:32:13Z

Description

This PR takes advantage of the generic extension functionality and adds .tag to Java Server Pages with a heuristic to correctly detect it.

I've gone with matching any of the possible directives that will appear in the JSP tag files as detailed at https://docs.oracle.com/javaee/1.4/tutorial/doc/JSPTags5.html

Fixes #3094, the oldest open issue in this repo right now.

I am associating a language with a new file extension.
- The new extension is used in hundreds of repositories on GitHub.com
  - Search results for each extension:
    - https://github.com/search?q=extension%3Atag+tag&type=Code
- I have included a real-world usage sample for all extensions added in this PR:
  - Sample source(s):
    - https://github.com/bzennn/WavyArch/blob/f6a3df9b2e714cc9948e473e20c3da7954653d1f/WavyArch/src/main/webapp/WEB-INF/tags/skeleton_page.tag
  - Sample license(s): MIT
- I have included a change to the heuristics to distinguish my language from others using the same extension.

Alhadis

Some discrepancies picked up from a cursory scan of Wikipedia¹ and one of its cited sources².

Also, it appears as if the language is known as "Jakarta Server Pages" now…?

lib/linguist/heuristics.yml

Co-authored-by: John Gardner <gardnerjohng@gmail.com>

Add generic .tag to JSP

ac21593

lildude requested a review from a team as a code owner September 1, 2022 16:32

lildude requested a review from Alhadis September 2, 2022 08:54

Alhadis requested changes Sep 3, 2022

View reviewed changes

lib/linguist/heuristics.yml Outdated Show resolved Hide resolved

Alhadis and others added 2 commits September 3, 2022 17:09

Merge branch 'master' into lildude/add-jsp-tag

e360bf8

Update lib/linguist/heuristics.yml

4f47f96

Co-authored-by: John Gardner <gardnerjohng@gmail.com>

Alhadis approved these changes Sep 5, 2022

View reviewed changes

lildude merged commit 1fbaa41 into master Sep 5, 2022

lildude deleted the lildude/add-jsp-tag branch September 5, 2022 08:26

github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024