Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruby versions for CI: drop 2.5 & add 3.1 #6159

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Update Ruby versions for CI: drop 2.5 & add 3.1 #6159

merged 4 commits into from
Nov 13, 2022

Conversation

chenrui333
Copy link
Contributor

@chenrui333 chenrui333 commented Nov 8, 2022

Description

Ruby 2.5 is already EOL, https://endoflife.software/programming-languages/server-side-scripting/ruby

Ruby 3.1 is now available too.

Checklist:

N/A

@chenrui333 chenrui333 requested a review from a team as a code owner November 8, 2022 22:22
@lildude lildude changed the title ci: drop ruby 2.5 Update Ruby versions for CI: drop 2.5 & add 3.1 Nov 12, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
This is needed on  3.1 onwards as `FNM_CASEFOLD` is no longer honoured on 3.1 as of ruby/ruby#4583 which brings the `Dir.glob` behaviour inline with what the https://docs.ruby-lang.org/en/3.1/File/File/Constants.html#FNM_CASEFOLD have been saying for years.
@lildude
Copy link
Member

lildude commented Nov 13, 2022

I've updated the samples test code as were relying on broken functionality which was fixed in ruby/ruby#4583 to bring the Dir.glob behaviour inline with what the docs have been saying for years.

@lildude lildude merged commit a595c22 into github-linguist:master Nov 13, 2022
@chenrui333 chenrui333 deleted the patch-1 branch December 22, 2022 17:52
zekigedir referenced this pull request Mar 12, 2023
* Add .cnf to INI

* Add openssl.cnf

* Increase acceptable errors

---------

Co-authored-by: Colin Seymour <colin@github.com>
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants
-