Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBS language #6369

Merged
merged 7 commits into from
May 30, 2023
Merged

Add RBS language #6369

merged 7 commits into from
May 30, 2023

Conversation

ybiquitous
Copy link
Contributor

@ybiquitous ybiquitous commented Apr 12, 2023 •
edited
Loading

Description

This pull request adds the RBS language. RBS (RuBy Signature) is a language to describe the structure of Ruby programs and has been developed and maintained by the Ruby official team.

Closes #6368

Checklist:

@ybiquitous ybiquitous marked this pull request as ready for review April 12, 2023 15:55
@ybiquitous ybiquitous requested a review from a team as a code owner April 12, 2023 15:55
Alhadis
Alhadis requested changes Apr 14, 2023
View reviewed changes
lib/linguist/languages.yml Outdated Show resolved Hide resolved
Alhadis
Alhadis requested changes Apr 14, 2023
View reviewed changes
lib/linguist/languages.yml Outdated Show resolved Hide resolved
ybiquitous and others added 2 commits April 15, 2023 07:58
@ybiquitous @Alhadis
Change RBS lang type from programming to data
1c76478 
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
@ybiquitous @Alhadis
Specify CodeMirror and ACE's Ruby modes to RBS
14e33df 
Co-authored-by: John Gardner <gardnerjohng@gmail.com>
@ybiquitous
Copy link
Contributor Author

@Alhadis Thanks for the review. I addressed all!

@Alhadis
Copy link
Collaborator

Alhadis commented Apr 14, 2023

@lildude This LGTM. 👍 Popularity requirements appear to checkout with ~10.7k search results for the .rbs extension (I've also encountered these files while hacking on Homebrew's source code, so I'm assuming this is a well-established and well-known file format in the Ruby community).

@ybiquitous
Copy link
Contributor Author

ybiquitous commented Apr 14, 2023 •
edited
Loading

I'm assuming this is a well-established and well-known file format in the Ruby community

Yes. Ruby 3.0 first released RBS as a language for static analysis (e.g. type-checking). See also the "Static Analysis" section in the Ruby 3.0 announcement.

Furthermore, RBS has been gradually growing with the community's support. For example, we can see many RBS files contributed by the community in the ruby/gem_rbs_collection repository (like DefinitelyTyped).

lildude
lildude approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude requested a review from a team as a code owner May 30, 2023 09:14
@lildude lildude added this pull request to the merge queue May 30, 2023
Merged via the queue into github-linguist:master with commit fd7a44b May 30, 2023
5 checks passed
@ybiquitous ybiquitous mentioned this pull request May 30, 2024
Open
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Alhadis Alhadis Alhadis approved these changes

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add language: RBS
3 participants
@ybiquitous @Alhadis @lildude
-